refactor: modularize shell feature lifecycles - #85
Merged
Conversation
Decompose the largest Aurora Shell modules into cohesive resource owners for Screenshot UI hooks, capture toolbar behavior and OCR sessions; tray viewport calculations and SNI entries; dock configuration, per-monitor bindings, contextual drag reveal and external-storage operations; Dash visibility, application activation, fixed items and spring loading; Aurora Menu recent-item parsing; Meeting Clock presentation and alerts; clipboard card construction; and IconWeave patching, inspection and window registration. Preserve the existing facades, public module APIs and DevTool contracts while making each extracted component responsible for its own actors, signals, cancellables, GLib sources and teardown. Introduce factory-based ManagedSource replacement and apply symmetric lifecycle orchestration across the affected modules, including explicit asynchronous identity checks, safe actor transition cleanup, conditional monkey-patch restoration and deterministic enable, disable and re-enable behavior. Tighten the implementation against the EGO review rules by removing redundant guards, lifecycle flags, defensive cleanup wrappers, unnecessary aliases and stale compatibility helpers, while documenting accepted analyzer findings and keeping settings, translations and review guidance synchronized. Expand pure unit coverage for tray layout, SNI icon handling and identity matching, dock configuration transitions, Dash visibility and window selection, Aurora Menu recent parsing, clipboard card classification, IconWeave scoring and registration, Meeting Clock alert timing and ManagedSource ordering. Extend Shell integration coverage for the refactored Dock, IconWeave and Volume Mixer paths so resource destruction and lifecycle restoration remain exercised in a real GNOME Shell environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decompose the largest Aurora Shell modules into cohesive resource owners for Screenshot UI hooks, capture toolbar behavior and OCR sessions; tray viewport calculations and SNI entries; dock configuration, per-monitor bindings, contextual drag reveal and external-storage operations; Dash visibility, application activation, fixed items and spring loading; Aurora Menu recent-item parsing; Meeting Clock presentation and alerts; clipboard card construction; and IconWeave patching, inspection and window registration. Preserve the existing facades, public module APIs and DevTool contracts while making each extracted component responsible for its own actors, signals, cancellables, GLib sources and teardown.
Introduce factory-based ManagedSource replacement and apply symmetric lifecycle orchestration across the affected modules, including explicit asynchronous identity checks, safe actor transition cleanup, conditional monkey-patch restoration and deterministic enable, disable and re-enable behavior. Tighten the implementation against the EGO review rules by removing redundant guards, lifecycle flags, defensive cleanup wrappers, unnecessary aliases and stale compatibility helpers, while documenting accepted analyzer findings and keeping settings, translations and review guidance synchronized.
Expand pure unit coverage for tray layout, SNI icon handling and identity matching, dock configuration transitions, Dash visibility and window selection, Aurora Menu recent parsing, clipboard card classification, IconWeave scoring and registration, Meeting Clock alert timing and ManagedSource ordering. Extend Shell integration coverage for the refactored Dock, IconWeave and Volume Mixer paths so resource destruction and lifecycle restoration remain exercised in a real GNOME Shell environment.